fix: resolve solution-wide analyzer warnings#2268
Merged
Merged
Conversation
Analyzer compliance: - update SharpAnalyzers and align centralized dependency versions - refactor generator, runtime, reflection, polyfill, benchmark, sample, and test code to satisfy active rules - extract stateless streaming JSON deserialization helpers and scope the net8 overload-priority polyfill Test infrastructure: - add a shared HttpClient test factory and update owned test clients - compose the exported code-fix provider without duplicate MEF registration - narrow helper visibility to its actual assembly scope Validation: - Debug and Release solution builds complete with 0 warnings and 0 errors - Microsoft Testing Platform/TUnit passes 7,341 tests with 0 failures and 0 skips - solution line coverage is 79.93%
|
ChrisPulman
marked this pull request as ready for review
July 21, 2026 11:45
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 187 191 +4
Lines 9835 9829 -6
Branches 1895 1894 -1
=========================================
- Hits 9835 9829 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
glennawatson
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Build-quality maintenance that resolves the solution-wide active analyzer diagnostics through code changes and dependency alignment, without adding diagnostic suppressions.
What is the new behavior?
main, including helper accessibility, member ordering, string construction, and HTTP client ownership.What is the current behavior?
The prior solution emits analyzer errors and warnings across production, generator, sample, benchmark, and test projects. Some test helpers also expose broader accessibility or shorter HTTP client lifetimes than their actual usage requires.
Checklist
Additional information
Validation run from
src:dotnet restore Refit.slnx --nologodotnet build Refit.slnx -c Debug --no-restore --nologo: 0 warnings, 0 errorsdotnet build Refit.slnx -c Release --no-restore --nologo: 0 warnings, 0 errorsdotnet test Refit.slnx --no-restore --no-build: 7,341 passed, 0 failed, 0 skippedCentral package updates in this branch include ReactiveUI.Primitives 7.0.0, SharpAnalyzers 3.33.0, ASP.NET Core 9.0.18/10.0.10, Microsoft.Extensions 10.0.10, System.Text.Json 10.0.10, and Microsoft.SourceLink.GitHub 10.0.301.
There are no public API baseline changes. Existing trim/AOT annotations moved with extracted implementation code; no new analyzer bypass was added.